Skip to content

Add useCrossVmSpendNft hook #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2025

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented May 22, 2025

Closes #2340

@jribbink jribbink requested a review from a team as a code owner May 22, 2025 01:25
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 282dfc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink marked this pull request as draft May 22, 2025 01:25
@jribbink jribbink changed the base branch from master to jribbink/cross-vm-balance May 22, 2025 01:27
Base automatically changed from jribbink/cross-vm-balance to master May 23, 2025 19:12
@jribbink jribbink marked this pull request as ready for review June 6, 2025 20:59
@jribbink jribbink changed the title Jribbink/cross vm nft spend Add useCrossVmSpendNft hook Jun 6, 2025
@jribbink jribbink changed the base branch from master to feature/cross-vm-hooks June 6, 2025 21:19
@jribbink jribbink force-pushed the feature/cross-vm-hooks branch from c9e2a80 to ad50c62 Compare June 6, 2025 21:25
@@ -2,19 +2,31 @@ export const CONTRACT_ADDRESSES = {
testnet: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing emulator or pushing that once we figure out how to solve it better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, once the changes have been pushed thru to the CLI we can do the emulator but right now the VM bridge doesn't deploy.


const {mutate: spendNft, mutateAsync: spendNftAsync, ...rest} = mutation

return {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a consistent format we are going to use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's the plan

@jribbink jribbink merged commit d7b673e into feature/cross-vm-hooks Jun 6, 2025
1 check passed
@jribbink jribbink deleted the jribbink/cross-vm-nft-spend branch June 6, 2025 21:58
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
chasefleming added a commit that referenced this pull request Jun 16, 2025
* PKG -- [transport-http] Create SubscriptionManager and subscribe function (#2019)

* PKG -- [sdk] Create SDK subscribe function (#2024)

* Update to latest streaming API changes (#2202)

* PKG -- [transport-http] Add Blocks DataProvider (#2033)

* PKG -- [transport-http] Add BlockDigests DataProvider (#2034)

* PKG -- [transport-http] Add BlockHeaders DataProvider (#2035)

* PKG -- [transport-http] Add TransactionStatuses DataProvider (#2041)

* PKG -- [transport-http] Add Events DataProvider (#2037)

* PKG -- [fcl] Expose new streaming endpoints (#2038)

* PKG -- [transport-http] Add AccountStatuses DataProvider (#2036)

* Switch to synchronous subscriptions with callback-based error reporting (#2242)

* Switch `fcl.events` to use new event streaming method (#2241)

* Fix resume args for `events` & `account_statuses` (#2249)

* Cleanup subscriptions types & align with decoded representation (#2256)

* Fix endpoint for WS subscriptions (#2277)

* Replace `fcl.tx` with realtime streaming (#2258)

* Reorganize subscriptions types (#2301)

* Add legacy `fcl.events` fallback for emulator (#2287)

* Add emulator fallback for fcl.tx (#2294)

* Fix resume args type check not checking if value is falsy (#2309)

* Add missing decoders (#2320)

* Improve WebSocket Lifecycle Management (#2312)

* Add changesets

* Fix Account Status Decoding

* Add `useIsCadenceWalletConnected` hook (#2326)

* Expose origin in `onMessageFromFCL` callback (#2384)

* Update and clean up WalletConnect dependencies (#2382)

* Deprecate manual `appIdentifier` in favour of window origin (#2378)

* Updated types to interfaces and comments cleanup (#2393)

* Updated types to interfaces and comments cleanup

* Added changeset

---------

Co-authored-by: mfbz <mfbz@users.noreply.github.com>

* Version Packages (#2371)

* Add `useFlowChainId` hook (#2367)

* Rename `useFlowTransaction` to `useFlowTransactionStatus` (#2413)

* Rename tx hook to tx status hook

* Fix import

---------

Co-authored-by: Chase Fleming <1666730+chasefleming@users.noreply.github.com>

* Add changeset (#2414)

* Add changeset

* Update moody-ligers-rule.md

* Update .changeset/moody-ligers-rule.md

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

---------

Co-authored-by: Chase Fleming <1666730+chasefleming@users.noreply.github.com>
Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Add comment about renaming (#2416)

Co-authored-by: Chase Fleming <1666730+chasefleming@users.noreply.github.com>

* Fix `useFlowRevertibleRandom` range (#2417)

* Update readme with `useFlowRevertibleRandom` hook (#2419)

Co-authored-by: Chase Fleming <1666730+chasefleming@users.noreply.github.com>

* Add `useCrossVmBatchTransaction` function (#2368)

* Refactored SDK package to TypeScript (#2352)

* Added onflow/typedefs and onflow/types types into sdk package

* Updated first part of files

* Updated encode and decode folders

* Updated send.js

* Updated sdk resolve files

* Fixed build problems

* Updated wallet-utils folder

* Moved typedefs and types back to their package

* Fixed build

* Refactored more js to ts files

* Fixed tests

* Added onflow/types re-export from sdk

* Added missing onflow/types package to sdk

* Updated readme with typescript examples

* Fixed build error on type problem

* Added changeset file

* Cleaned up types and docs

* Minor comments fix

* Removed unused cast

* Added suport to conditional interaction callbacks in build

* After install update

* Fixed build-transaction input params

* Updated send function null check

* Re-added resolve comments to two special functions

* Added Voucher export from sdk

* Improved input params for send function

* Renamed InteractionCallback to InteractionBuilderFn

* Improve with central function definition from interaction file

* Improved atBlockId validator types

* Strongly typed voucher intercept param

* Improved signing function interface and minor refactoring

* Refactored AcctFn function name

* Refactored AccountFn name

---------

Co-authored-by: mfbz <mfbz@users.noreply.github.com>

* Fix payload type

* Fix payload decoding

* Fix Typos in Documentation Files (#2420)

* Enter alpha mode (#2421)

* Version Packages (alpha) (#2396)

* Fix current user returning false before checking authenticated (#2428)

Co-authored-by: Chase Fleming <1666730+chasefleming@users.noreply.github.com>

* Allow undefined value for `useFlowTransactionStatus` (#2439)

* Fixed fcl.mutate hanging (#2434)

* Fixed fcl-mutate not working

* Update packages/sdk/src/block/block.ts

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Update packages/sdk/src/block/block.ts

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Update packages/sdk/src/block/block.ts

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Update packages/sdk/src/node-version-info/node-version-info.ts

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Update packages/sdk/src/resolve/resolve.ts

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Added validator improvement

* Create four-frogs-jump.md

---------

Co-authored-by: mfbz <mfbz@users.noreply.github.com>
Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>

* Version Packages (alpha) (#2440)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Unsubscribe from transaction statuses once sealed (#2461)

* Version Packages (alpha) (#2465)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Exit alpha (#2466)

* Rename `rawSubscribe` to `subscribeRaw` (#2463)

* Version Packages (#2467)

* Fix `useFlowQuery` query key for script args (#2433)

* Version Packages (#2469)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add `useCrossVmTokenBalance` hook (#2398)

* Switch cross VM balance to vault identifier (#2486)

* Version Packages (#2471)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Export `useCrossVmTokenBalance` hook (#2491)

* Version Packages (#2494)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add `useCrossVmSpendNft` hook (#2460)

* Add `useCrossVmSpendFt` hook (#2499)

* Change `useCrossVmBatchTransaction` to only return Cadence TX hash (#2502)

* Version Packages (#2504)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Make `useFlowChainId` args consistent with other hooks (#2506)

* Run prettier

* Run install

* Update packages/fcl-core/CHANGELOG.md

Co-authored-by: Michael Fabozzi <39808567+mfbz@users.noreply.github.com>

* Fix import

* Add tailwind merge

* Update packages/fcl-react-native/CHANGELOG.md

Co-authored-by: Michael Fabozzi <39808567+mfbz@users.noreply.github.com>

* Update packages/fcl/CHANGELOG.md

Co-authored-by: Michael Fabozzi <39808567+mfbz@users.noreply.github.com>

* Update packages/sdk/CHANGELOG.md

Co-authored-by: Michael Fabozzi <39808567+mfbz@users.noreply.github.com>

---------

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>
Co-authored-by: Jordan Ribbink <jribbink@telus.net>
Co-authored-by: Michael Fabozzi <39808567+mfbz@users.noreply.github.com>
Co-authored-by: mfbz <mfbz@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chase Fleming <1666730+chasefleming@users.noreply.github.com>
Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-VM Spend NFT Hook
2 participants